std: Decouple network streams from fs.File

[LemonBoy]

The overlap between files and sockets is minimal and lumping them
together means supporting only a small subset of the functionalities
provided by the OS.
Moreover the socket and file handles are not always interchangeable: on
Windows one should use Winsock's close() call rather than the one used
for common files.

[Aransentin]

Since it's separated we can call shutdown on the socket before closing it now. Currently the connection is always destroyed with an RST packet instead of the standard FIN/ACK goodbye, which works but is kinda dirty.

The connection might still not be established if the connection is non-blocking however, and so calling shutdown would be an error. I assume some sort of "connection has actually been established" flag would be necessary to solve that.

[Aransentin]

I'd also consider adding functions to Stream to turn on TCP_NODELAY and/or SO_KEEPALIVE on the underlying socket; options which (arguably) most TCP streams should have enabled.

[LemonBoy]

Currently the connection is always destroyed with an RST packet instead of the standard FIN/ACK goodbye, which works but is kinda dirty.

I think having a separate shutdown method is preferable as that's a different hangup sequence than the close one, the user may want to use one or the other depending on their requirements.

I'd also consider adding functions to Stream to turn on TCP_NODELAY and/or SO_KEEPALIVE on the underlying socket; options which (arguably) most TCP streams should have enabled.

There are a few options that deserve getters/setters: nodelay, keepalive, linger and probably more.

I think we can start a new ticket to brainstorm what's needed in the net API.

[frmdstryr]

I think we can start a new ticket to brainstorm what's needed in the net API.

Agree... net also need to support timeouts on read/write since it currently cannot prevent DOS attacks.

[LemonBoy]

Is Windows and/or Azure being a bunch of hot garbage again? Or did I mess up the version check?

[andrewrk]

I support this change, let's just make sure it's CI green