stage2: store Cache files in a map data structure #7393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache now stores files as an StringArrayListHashMap instead of an ArrayList. The key is the resolved file path, to avoid adding the same file multiple times into the cache system when it is depended on multiple times. This avoids re-hashing file contents that have already been inserted into the cache. This was an attempt to fix #7308, but it is solving a different problem. I do think it is worth considering this improvement regardless. On the other hand, it might be duplicated effort since the layer of code above this one probably wants to do its own de-duplication as well. This implementation would be much nicer with #7391.
andrewrk
added
proposal
|
Well tests are failing and I wasn't even sure if this was an improvement, so I'm going to throw this patch in the garbo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache now stores files as an StringArrayListHashMap instead of an
ArrayList. The key is the resolved file path, to avoid adding the same
file multiple times into the cache system when it is depended on
multiple times. This avoids re-hashing file contents that have already
been inserted into the cache.
This was an attempt to fix #7308, but it is solving a different problem.
I do think it is worth considering this improvement regardless. On the
other hand, it might be wasted CPU cycles / code bloat since the layer of code above
this one probably wants to do its own de-duplication as well.
This implementation would be much nicer with #7391.