std: Deprecate 'x'/'X'/'e'/'E' special cases for u8 slices #8007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe |
|
No. |
|
Rebased, note that this reverts #8031 as the deprecation warnings were added (and removed) within the same release. |
Let's follow the road paved by the removal of 'z'/'Z', the Formatter pattern is nice enough to let us remove the remaining four special cases and declare u8 slices free from any special casing!
andrewrk
approved these changes
Mar 1, 2021
daurnimator
reviewed
Mar 1, 2021
|
|
||
| /// Return a Formatter for a []const u8 where every byte is formatted as a pair | ||
| /// of uppercase hexadecimal digits. | ||
| pub fn fmtSliceHexUpper(bytes: []const u8) std.fmt.Formatter(formatSliceHexUpper) { |
There was a problem hiding this comment.
I don't love that we have different functions for this for upper vs lower case.
Could we instead take the case as an argument?
pub fn fmtSliceHex(bytes: []const u8, case: enum{Upper, Lower}) std.fmt.Formatter(formatSliceHex) {
There was a problem hiding this comment.
No strong opinion on having a single formatter, I went with two separate ones to keep it close to the x / X.
(IIRC there's a stage1 bug regarding comptime anonymous enum arguments, check out #3707)
andrewrk
added
breaking
LemonBoy
added a commit
to LemonBoy/zig
that referenced
this pull request
Mar 6, 2021
Following ziglang#8007 and ziglang#8137 let's get rid of the last weird format.
LemonBoy
added a commit
to LemonBoy/zig
that referenced
this pull request
Mar 6, 2021
Following ziglang#8007 and ziglang#8137 let's get rid of the last weird format.
LemonBoy
added a commit
to LemonBoy/zig
that referenced
this pull request
Mar 6, 2021
Following ziglang#8007 and ziglang#8137 let's get rid of the last weird format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's follow the road paved by the removal of 'z'/'Z', the Formatter
pattern is nice enough to let us remove the remaining four special cases
and declare u8 slices free from any special casing!