wasm: produce static lib by default and rename produced object files to simply .o from .o.wasm #8857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the behaviour for other targets in that ``` zig build-lib math.zig -target wasm32-freestanding ``` produces now `libmath.a` while ``` zig build-lib math.zig -dynamic -target wasm32-freestanding ``` is required to create a loadable Wasm module.
kubkon
added
the
breaking
This should offer more compatibility with external tooling when cross-compiling to wasm with zig.
kubkon
changed the title
|
Yes! Consistency with other platforms and compilers is great. Also, having a different extension for objects previously confused |
jedisct1
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produce static lib by default
This matches the behaviour for other targets in that
produces now
libmath.awhileis required to create a loadable Wasm module.
Rename produced object files to .o from .o.wasm
This should offer more compatibility with external tooling when cross-compiling to wasm with zig.