stdlib: Add Intel HEX support to InstallRawStep #9636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehaas
force-pushed
the
hexfiles
branch
2 times, most recently
from
21f006a to
865ac72
Compare
|
Drone failed on |
andrewrk
reviewed
Sep 1, 2021
lib/std/build/InstallRawStep.zig
Outdated
| @@ -13,6 +13,7 @@ const fs = std.fs; | |||
| const io = std.io; | |||
| const sort = std.sort; | |||
| const warn = std.debug.warn; | |||
| const nl = std.cstr.line_sep; | |||
There was a problem hiding this comment.
shouldn't the newline depend on the target, not the host system running the compiler?
There was a problem hiding this comment.
Upon further investigation it appears to always end in CRLF. Source: https://developer.arm.com/documentation/ka003292/latest and also running objcopy -O ihex test.o test.hex on a native .o file for a x86_64 linux system. So I'll update it to always to \r\n
This allows writing HEX files with `exe.installRaw`, where `exe` is a
`LibExeObjStep`. A HEX file will be written if the file extension is `.hex`
or `.ihex`, otherwise a binfile will be written. The output format can be
explicitly chosen with `exe.installRawWithFormat("filename", .hex);`
(or `.bin`)
Part of ziglang#2826
Co-authored-by: Akbar Dhanaliwala <[email protected]>
Co-authored-by: Akbar Dhanaliwala <[email protected]>
andrewrk
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows writing HEX files with
exe.installRaw, whereexeis aLibExeObjStep. A HEX file will be written if the file extension is.hexor.ihex, otherwise a binfile will be written. The output format can be explicitly chosen withexe.installRawWithFormat("filename", .hex);(or.bin)Part of #2826