Fix bug in exp2() #9999
Merged
Fix bug in exp2() #9999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiehuis
reviewed
Oct 22, 2021
LewisGaul
commented
Oct 22, 2021
|
Thanks! The failing CI is #10008, so we'll take the strategy of merging now and then dealing with any breakage later, since this fixes a math function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9991.
Fix bad translation from C - lots of reliance on implicit overflow/truncation/bit manipulation!
Added testcases reproduced the failure (for
f64only), now passing.The method used in
exp2_32()is slightly different toexp2_64(), but there was an overflow addition that seemed to also need fixing to mirror musl (old implementation).