Bump up dependencies on pyserial and pyserial-asyncio #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump up dependencies on pyserial and pyserial-asyncio for projects other projects that use this library but are not Home Assistant. Adminiuga did the same dependency version bump for Home Assistant in home-assistant/core#44089 pyserial-asyncio depends on pyserial and this bumps pyserial-asyncio to 0.5 version release and pyserial to 3.5 version release. https://github.com/pyserial/pyserial-asyncio/releases/tag/v0.5 https://github.com/pyserial/pyserial/releases/tag/v3.5
Adminiuga
requested changes
Dec 11, 2020
Would it maybe be OK with "pyserial>=3.5" and "pyserial-asyncio>=0.5" or alternatively some previous versions? |
Change from == to >= for pyserial 3.5 and pyserial-asyncio 0.5
Changed from == to >= for pyserial 3.5 and pyserial-asyncio 0.5 as suggested for zigpy-znp in zigpy/zigpy-znp#50 |
Asked in zigpy/zigpy-znp#50 if the PR home-assistant/core#44089 not in effect pin these to specific versions in Home Assistant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up dependencies on pyserial and pyserial-asyncio for projects other projects that use this library but are not Home Assistant.
Adminiuga did the same dependency version bump for Home Assistant in home-assistant/core#44089
pyserial-asyncio depends on pyserial and this bumps pyserial-asyncio to 0.5 version release and pyserial to 3.5 version release.
https://github.com/pyserial/pyserial-asyncio/releases/tag/v0.5
https://github.com/pyserial/pyserial/releases/tag/v3.5