Skip to content

Don't consume data when processing ZDO device_annce message. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2019

Conversation

Adminiuga
Copy link
Collaborator

Fixes Failed to parse message, data is too short when a device joins/rejoins network.

2019-06-30 18:45:27 DEBUG (MainThread) [zigpy_xbee.uart] Frame received: b'\x91\x00\x0bW\xff\xfeKK@\xa0!\x00\x00\x00\x13\x00\x00\x02\x81!\xa0@KK\xfe\xffW\x0b\x00\x80'
2019-06-30 18:45:27 DEBUG (MainThread) [zigpy_xbee.api] Frame received: explicit_rx_indicator
2019-06-30 18:45:27 DEBUG (MainThread) [zigpy_xbee.api] _handle_explicit_rx: (00:0b:57:ff:fe:4b:4b:40, 0xa021, 0, 19, 2, b'8121a0404b4bfeff570b0080')
2019-06-30 18:45:27 INFO (MainThread) [zigpy_xbee.zigbee.application] New device joined: NWK 0xa021, IEEE 00:0b:57:ff:fe:4b:4b:40
2019-06-30 18:45:27 INFO (MainThread) [zigpy.application] Device 0xa021 (00:0b:57:ff:fe:4b:4b:40) joined the network
2019-06-30 18:45:27 ERROR (MainThread) [zigpy_xbee.zigbee.application] Failed to parse message (b'80') on cluster 19, because Data is too short to contain 2 bytes

@Adminiuga Adminiuga force-pushed the fixes/zdo-dev-annce branch from d37be3d to 379c155 Compare June 30, 2019 23:54
@coveralls
Copy link

coveralls commented Jun 30, 2019

Pull Request Test Coverage Report for Build 145

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 141: 0.0%
Covered Lines: 643
Relevant Lines: 643

💛 - Coveralls

@Adminiuga Adminiuga force-pushed the fixes/zdo-dev-annce branch from 379c155 to bc3549b Compare July 1, 2019 00:25
@Adminiuga Adminiuga force-pushed the fixes/zdo-dev-annce branch from bc3549b to 86472d8 Compare July 1, 2019 00:28
@Adminiuga Adminiuga merged commit 4046dcd into zigpy:dev Jul 6, 2019
@Adminiuga Adminiuga deleted the fixes/zdo-dev-annce branch July 6, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants