Skip to content

pass down NETWORK_COMMISSIONING_TIMEOUT to request() #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dumpfheimer
Copy link
Contributor

The network formation timemout was not passed down to request, which meant it was cancelled with the default AREQ timeout. Network formation can also take longer than 30s in a noisy environment which is why I increased it to 60. If the request is cancelled and zigpy restarts. The following Ping seems to crash the controller if the formation has not completed in the mean time.

@codecov-commenter
Copy link

Codecov Report

Base: 98.50% // Head: 98.50% // No change to project coverage 👍

Coverage data is based on head (3b896cc) compared to base (ca061f4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #183   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          43       43           
  Lines        3806     3806           
=======================================
  Hits         3749     3749           
  Misses         57       57           
Impacted Files Coverage Δ
zigpy_znp/api.py 96.69% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@puddly puddly merged commit 2746005 into zigpy:dev Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants