Skip to content

Use shared PyPi release workflow #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

TheJulianJES
Copy link
Contributor

Migrates the PyPi publishing workflow to the shared workflow. (Reference: zigpy/zigpy#1239)

The previous publishing workflow for zigpy-znp used Python 3.8
However, zigpy-znp already uses the shared CI workflow with Python 3.9.15 (like the other repos), so it should be good to also change it here.

@puddly
Copy link
Collaborator

puddly commented Aug 2, 2023

Thanks! Do you think we should drop the entire with section and stick to the workflow default of 3.9 instead of specifying it in each repo? All of the repos should have the same Python version support so we should be able to centralize it.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4291267) 98.49% compared to head (69e07cb) 98.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #222   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          43       43           
  Lines        3787     3787           
=======================================
  Hits         3730     3730           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES
Copy link
Contributor Author

Yeah, good idea.

Should we also drop it for the (shared) CI workflow then? (assuming the defaults in the CI + publish workflow are updated simultaneously)

@TheJulianJES
Copy link
Contributor Author

TheJulianJES commented Aug 2, 2023

Also, although not important, do we maybe want to use published as a trigger instead of released?

zigpy-znp was the only repo that used it before (all others released), but I feel like it's more correct to also upload possible "pre-releases" to PyPi, even though pre-releases aren't used at the moment of course.

EDIT: Changed to published for now, as it's (IMO) slightly more correct.
(also, are the tests a bit flaky?)

This would also upload "pre-releases" to PyPi
@puddly
Copy link
Collaborator

puddly commented Aug 2, 2023

I think there may be some race condition with coverage between the various Python versions? This is the line causing coverage issues:

image

@puddly puddly merged commit e60c556 into zigpy:dev Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants