Skip to content

Supports non ascii characters in example description and resource name #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2014
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/rspec_api_documentation/views/markup_example.rb
Original file line number Diff line number Diff line change
@@ -19,11 +19,11 @@ def respond_to?(method, include_private = false)
end

def dirname
resource_name.downcase.gsub(/[^0-9a-z.\-]+/, '_')
resource_name.downcase.gsub(/\s+/, '_')
end

def filename
basename = description.downcase.gsub(/\s+/, '_').gsub(/[^a-z_]/, '')
basename = description.downcase.gsub(/\s+/, '_').gsub(Pathname::SEPARATOR_PAT, '')
basename = Digest::MD5.new.update(description).to_s if basename.blank?
"#{basename}.#{extension}"
end
2 changes: 1 addition & 1 deletion lib/rspec_api_documentation/writers/json_writer.rb
Original file line number Diff line number Diff line change
@@ -78,7 +78,7 @@ def dirname
end

def filename
basename = description.downcase.gsub(/\s+/, '_').gsub(/[^a-z_]/, '')
basename = description.downcase.gsub(/\s+/, '_').gsub(Pathname::SEPARATOR_PAT, '')
"#{basename}.json"
end

5 changes: 2 additions & 3 deletions spec/views/html_example_spec.rb
Original file line number Diff line number Diff line change
@@ -13,12 +13,11 @@
end

describe "multi charctor example name" do
let(:label) { "コーヒーが順番で並んでいること" }
let(:label) { "Coffee / Teaが順番で並んでいること" }
let(:example) { group.example(label) {} }

it "should have downcased filename" do
filename = Digest::MD5.new.update(label).to_s
expect(html_example.filename).to eq(filename + ".html")
expect(html_example.filename).to eq("coffee__teaが順番で並んでいること.html")
end
end
end
12 changes: 12 additions & 0 deletions spec/writers/json_example_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# -*- coding: utf-8 -*-
require 'spec_helper'

describe RspecApiDocumentation::Writers::JsonExample do
let(:configuration) { RspecApiDocumentation::Configuration.new }

describe '#filename' do
specify 'Hello!/ 世界' do |example|
expect(described_class.new(example, configuration).filename).to eq("hello!_世界.json")
end
end
end