Allow Class Resources, call #to_s for defined resource_name
#238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using a class as the resource: resource Order do end The resource_name will be a class, which causes issues when sorting for sections. By calling `#to_s` on the `args.first` when first dealing with the resource we can ensure that we are always working with a string for the resource_name.
|
Thanks! |
oestrich
added a commit
that referenced
this pull request
Dec 23, 2015
Allow Class Resources, call `#to_s` for defined resource_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using a class as the resource:
The
resource_namewill be a class, which causes issues when sorting forsections. By calling
#to_son theargs.firstwhen first dealing withthe resource we can ensure that we are always working with a string for
the
resource_name.Also refactored to use a ternary operator instead of a one-line
if else end.