Skip to content

Fix curl escape #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2013
Merged

Fix curl escape #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c66c35
escape quotes in curl data (fixes https://github.com/zipmark/rspec_ap…
mrbrdo Mar 19, 2013
9a90a64
fix specs, coerce data into string (i.e. handle nil case)
mrbrdo Mar 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/rspec_api_documentation/curl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ def get_data
end

def post_data
"-d \"#{data}\""
escaped_data = data.to_s.gsub("'", "\\u0027")
"-d '#{escaped_data}'"
end

private
Expand Down
4 changes: 2 additions & 2 deletions spec/curl_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

it { should =~ /^curl/ }
it { should =~ /http:\/\/example\.com\/orders/ }
it { should =~ /-d "order%5Bsize%5D=large&order%5Btype%5D=cart"/ }
it { should =~ /-d 'order%5Bsize%5D=large&order%5Btype%5D=cart'/ }
it { should =~ /-X POST/ }
it { should =~ /-H "Accept: application\/json"/ }
it { should =~ /-H "X-Header: header"/ }
Expand Down Expand Up @@ -50,7 +50,7 @@

it { should =~ /^curl/ }
it { should =~ /http:\/\/example\.com\/orders\/1/ }
it { should =~ /-d "size=large"/ }
it { should =~ /-d 'size=large'/ }
it { should =~ /-X PUT/ }
it { should =~ /-H "Accept: application\/json"/ }
it { should =~ /-H "X-Header: header"/ }
Expand Down