Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Use root locale when changing case in java #2230

Closed
wants to merge 1 commit into from
Closed

Conversation

halaei
Copy link
Contributor

@halaei halaei commented Feb 2, 2022

Not setting locale for language/country neutral operation may cause bug depending on the default locale.
See https://docs.oracle.com/javase/7/docs/api/java/util/Locale.html#ROOT

Note: I am just searching for toLowerCase() and toUppercase() in my project's dependencies and send the same PR, in order to potentially raise the awareness. Although I've seen the lack of explicit locale has caused issues for us, I am not sure if react-native-push-notification is actually affected.

Example related issue: joltup/rn-fetch-blob#573

@Dallas62
Copy link
Collaborator

Dallas62 commented Feb 2, 2022

https://github.com/zo0r/react-native-push-notification#state-of-the-repository

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Feb 3, 2023
@github-actions github-actions bot closed this Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants