#80 implementation for proof of ownership (#90)

* #80 add core node admin services

* improve generate proof of ownership function

* on progress proof of ownership validation

* node message conversion from byte

* add nodeAdminCoreService test

* add config owner acc address

* recompiled schema after refactoring ProofOfOwnership protobuf
Refactored signature.go: changed method name from SignBlock  to SignByNode (to generalise message that are signed using node pri key)
Added GetBlockHash to blockUtil.go
Refactored nodeAdminCoreService.GenerateProofOfOwnership: now reusing methods from other service and packages to reduce duplication of business logic
added helpers interface and injected into NodeAdmin stuct to make its methods mockable
refactored unit test for GenerateProofOfOwnership

* added GetBlockByHeight to blockService and creted unit test
refactored ValidateProofOfOwnership method to reuse already (previously) implemented methods

* finished refactoring ValidateProofOfOwnership
moved all helper (mockable) methods to NodeAdminServiceHelpersInterface
fixed bug in GetSize for accountType (min size in bytes for an integer in protobuf v3 is 4, so we cannot have 2 or 1 byte fields)

* fixed loading config params: using configuration already loaded in main.go
fixed relative unit tests

* injected BlockService into NodeAdminService to make it mockable and refactored relative code/tests

* simplified unit tests by removing unecessary mocked queries (since now we mock direclty the blockservice, which is the one where queries needed to be mocked)

Author: komodo2662

common/constant/node.go

@@ -0,0 +1,6 @@
+package constant
+
+var (
+	// ProofOfOwnershipExpiration number of blocks after a proof of ownership message 'expires' (is considered invalid)
+	ProofOfOwnershipExpiration uint32 = 100
+)

common/crypto/signature.go

@@ -8,7 +8,7 @@ import (
 type (
 	SignatureInterface interface {
 		Sign(payload []byte, accountType uint32, accountAddress, seed string) []byte
-		SignBlock(payload []byte, nodeSeed string) []byte
+		SignByNode(payload []byte, nodeSeed string) []byte
 		VerifySignature(payload, signature []byte, accountType uint32, accountAddress string) bool
 	}
 
@@ -37,8 +37,8 @@ func (sig *Signature) Sign(payload []byte, accountType uint32, accountAddress, s
 	}
 }
 
-// SignBlock special method for signing block only, there will be no multiple signature options
-func (*Signature) SignBlock(payload []byte, nodeSeed string) []byte {
+// SignByNode special method for signing block only, there will be no multiple signature options
+func (*Signature) SignByNode(payload []byte, nodeSeed string) []byte {
 	nodePrivateKey := ed25519GetPrivateKeyFromSeed(nodeSeed)
 	return ed25519.Sign(nodePrivateKey, payload)
 }

common/crypto/signature_test.go

@@ -83,7 +83,7 @@ func TestSignature_SignBlock(t *testing.T) {
 		want []byte
 	}{
 		{
-			name: "SignBlock:success",
+			name: "SignByNode:success",
 			args: args{
 				payload:  []byte{12, 43, 65, 65, 12, 123, 43, 12, 1, 24, 5, 5, 12, 54},
 				nodeSeed: "concur vocalist rotten busload gap quote stinging undiluted surfer goofiness deviation starved",
@@ -96,8 +96,8 @@ func TestSignature_SignBlock(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			s := &Signature{}
-			if got := s.SignBlock(tt.args.payload, tt.args.nodeSeed); !reflect.DeepEqual(got, tt.want) {
-				t.Errorf("Signature.SignBlock() = %v, want %v", got, tt.want)
+			if got := s.SignByNode(tt.args.payload, tt.args.nodeSeed); !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("Signature.SignByNode() = %v, want %v", got, tt.want)
 			}
 		})
 	}