#80 implementation for proof of ownership #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored signature.go: changed method name from SignBlock to SignByNode (to generalise message that are signed using node pri key) Added GetBlockHash to blockUtil.go Refactored nodeAdminCoreService.GenerateProofOfOwnership: now reusing methods from other service and packages to reduce duplication of business logic added helpers interface and injected into NodeAdmin stuct to make its methods mockable refactored unit test for GenerateProofOfOwnership
refactored ValidateProofOfOwnership method to reuse already (previously) implemented methods
moved all helper (mockable) methods to NodeAdminServiceHelpersInterface fixed bug in GetSize for accountType (min size in bytes for an integer in protobuf v3 is 4, so we cannot have 2 or 1 byte fields)
iltoga
approved these changes
Aug 3, 2019
andy-shi88
reviewed
Aug 3, 2019
|
please let's know if changes are updated, [excluding the marshal one 👍 ] |
added 2 commits
August 5, 2019 10:37
…in.go fixed relative unit tests
astaphobia
reviewed
Aug 5, 2019
added 2 commits
August 5, 2019 13:49
…efactored relative code/tests
…w we mock direclty the blockservice, which is the one where queries needed to be mocked)
andy-shi88
approved these changes
Aug 5, 2019
astaphobia
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implementation for proof of ownership as stated in #80
Breakdown
Reference Issue
Close #80