Design: Remove *Length variables #136
Description
Description
In several data model we have *Length variable to define the length of the next variable in the bytes. @capt4ce bring a good point of wether we need the *Length or not.
- Proposal:
We should use thelengthonly in theTransactionByteslike
length := len(tx.SenderAddressLength)
buffer.Write(length)
buffer.Write(tx.SenderAddress)
(`[....1,0,0,0, ...]`)
instead of in the proto structure like
Transaction {
SenderAccountAddressLength uint32
SenderAddress string
}
buffer.Write(tx.SenderAddressLength)
buffer.Write(tx.SenderAddress)
Breakdown
- Remove
*lengthvariable in
Transaction.*AccountAddress
Transaction.TransactionBodyLength
NodeRegistration.NodeAddressLength
Additional Diagram / File
Put additional diagram or file