Skip to content

Bug: CanPersistBlock Always False On Small Network #832

@andy-shi88

Description

@andy-shi88

Description

Current check on block persistance only limit to 2 persist round,

  • previous round
  • current round

on small network (less than 5) with some configuration on smithing period and smithing gap, the time overlap causes the valid blocksmith time always skipped.

say blocksmith_a can persist at prev(100 - 110), current(120 - 130), next(140 - 150)
if we cover 2 round, by the time we reach 100++, our previous become (120 - 130) and current become (140 - 150)

That's why need to add previous2n into the comparison scope to handle small network.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BACKWARD_COMPATIBLErequire changes that are backward compatible, no reset requiredBUGSomething isn't workingCOREcore functionalitiesHIGH_PRIORITYneeded ASAP for current sprint

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions