Add Merkle Root on Spine Block #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukrawidhyawan
requested review from
andy-shi88,
astaphobia,
capt4ce and
iltoga
as code owners
sukrawidhyawan
changed the title
…add-merkle-tree-in-spine-chain
andy-shi88
approved these changes
Sep 28, 2020
iltoga
approved these changes
Sep 29, 2020
| @@ -1004,8 +1005,8 @@ func start() { | |||
|
|
|||
| mainchainSyncChannel := make(chan bool, 1) | |||
| mainchainSyncChannel <- true | |||
| startSpinechain() | |||
There was a problem hiding this comment.
why starting mainchain before spinechain?
There was a problem hiding this comment.
because the mainchain is injected into spine chain, need the main service ready first
capt4ce
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Merkle root & Merkle tree fields on main & spine block. For Spine block, merkle root is build from main blocks and Reference Block Height is the last main block that included in the spine block merkle root. Add fields
merkle_root,merkle_tree,reference_block_heightin main & spine block.Breakdown
merkle_root,merkle_tree,reference_block_heightReference Issue
Close #numberIssue
Schema PR changes
zoobc/zoobc-schema#156
Step to Test (optional)
Run multiple nodes in local