-
Notifications
You must be signed in to change notification settings - Fork 3
[FIX] - Multi signature offchain flow #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
astaphobia
wants to merge
25
commits into
develop
Choose a base branch
from
multisignature-can-offchain-flow
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
720da89
to
0587003
Compare
a197196
to
6ae6c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR include enhancement on multi signature transaction stuff, allowing post a multi signature transaction in offchain flow.
In OffChain case if one of
SignatureInfo.Signatures
is a multisignature address and the Key format would be like:MultiSignature Key
AccountType
MultiSignatureInfoLength
MultiSignatureInfo
pure in bytes format.If One of MultiSignature Key participant is a MultiSignatureAddress again, it should repeat the MultiSignature Key format again.
And otherwise Key should account address bytes format.
MultiSignature Value
OffChain flow can contains 3 nested MultiSignature Key
method
ParseSignatureInfoBytesAsCandidates
will called in recursively to parsingKey
of SignatureInfo.Signatures`Breakdown
Reference Issue
Close #1337
Refer also on: zoobc/zoobc-schema#173