Skip to content

1190 bugfix blocksmith selection #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2020
Merged

1190 bugfix blocksmith selection #1357

merged 2 commits into from
Nov 18, 2020

Conversation

andy-shi88
Copy link
Contributor

@andy-shi88 andy-shi88 commented Nov 18, 2020

Description

inconsistent uses of previous block timestamp in determining next block's smithing time, caused the node won't continue to smith after stopped (even without reset)

Breakdown

  • every calculation use estimated persist time
  • cumulative difficulty calculated from skipped blocksmith instead of smithing round (which can cause 2 different quality block having same cumm-diff)
  • calculate cummulative difficulty after block is sure to be persisted, so we don't calculate for blockpool block

Fix #1190

Copy link
Contributor

@iltoga iltoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@iltoga iltoga merged commit 635a80d into zoobc:develop Nov 18, 2020
@andy-shi88 andy-shi88 removed their assignment Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance: Blocksmith Selection
3 participants