1346 Full Cache Mempool Transaction (unsafe mempool) #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukrawidhyawan
requested review from
andy-shi88,
astaphobia,
capt4ce and
iltoga
as code owners
iltoga
approved these changes
Nov 20, 2020
core/service/mempoolCoreService.go
Outdated
| switch { | ||
| case mps.lastIncomingTransactionTime.IsZero(): | ||
| isApplyInCache = false | ||
| case time.Since(mps.lastIncomingTransactionTime).Seconds() < 1, mps.MempoolUnsaveCacheStorage.GetTotalItems() > 0: |
There was a problem hiding this comment.
I think better to use a constant instead of hardcoded time duration. we might be able to tune this setting on high end hardware
There was a problem hiding this comment.
added, thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Unsave mempool transaction to reduce write data into DB base.
Current implementation when last incoming transaction less than 1 second OR unsafe cache mempool not empty new incoming transaction will come to full cache mempool.
Full cache mempool will move into normal mempool (DBmempool) in every 5second
Breakdown
ApplyUnconfirmed&EscrowApplyUnconfirmedto save transaction into full cache mempoolAddAccountSpendableBalanceInCache&UpdateAccountSpendableBalanceInCachein Balance HelperReference Issue
Close #1346
Step to Test (optional)
SPam with 80tx/2s
Balance after spam
