1403 Adjust Validate Transaction for Checking Balance #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukrawidhyawan
requested review from
andy-shi88,
astaphobia,
capt4ce and
iltoga
as code owners
andy-shi88
approved these changes
Dec 7, 2020
astaphobia
approved these changes
Dec 7, 2020
iltoga
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust Validate transaction to check actual balance instead of spendable balance when push block. Validate to check spendable balance only when receiving a transaction when post transaction or from Peer.
Breakdown
checkOnSpendableBalanceon Validate & EscrowValidate transaction to give option check into spendable balance or actual balance.Reference Issue
Close #1403
Step to Test (optional)
run multiple nodes