-
Notifications
You must be signed in to change notification settings - Fork 3
146 receipt #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
146 receipt #195
Conversation
} | ||
|
||
func startServices(queryExecutor query.ExecutorInterface, ownerAccountAddress string) { | ||
startP2pService() | ||
func startServices() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
p2p/p2p.go
Outdated
mempoolServices map[int32]coreService.MempoolServiceInterface, | ||
) { | ||
// initialize log | ||
p2pLogger, err := util.InitLogger(".log/", "debug.log") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to specify log levels, LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may need to pull the latest develop branch, on it.
nodeSecretPhrase, | ||
) | ||
// start listening on peer port | ||
go func() { // register handlers and listening to incoming p2p request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we put gorountines :87-99
to single goroutine? how about that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice idea, updating
This PR is for #146 send receipt, For collecting receipt right now it just store everything to |
|
||
configPath := viper.GetString("configPath") | ||
nodeKeyFile := viper.GetString("nodeKeyFile") | ||
smithing = viper.GetBool("smithing") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this boolean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes until fully integrated to node registry for smithing
The Download blockchain process in #220 has already included transactions into the blocks to be downloaded |
Description
Add receipt functionality and refactor p2p module.
Breakdown
Test recovered
Reference Issue
Close #146
Step to Test (optional)
go test ./...
Functionality
run second node:
go run main.go --config-postfix 2
run main node (smithing=true):
go run main.go
it should: