202 node reciepts collection #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eciepts-collection
…eciepts-collection
…eciepts-collection
astaphobia
requested review from
andy-shi88,
iltoga,
capt4ce,
komodo2662 and
sukrawidhyawan
iltoga
approved these changes
Sep 24, 2019
common/query/batchReceiptQuery.go
Outdated
| ) | ||
| newLimit := limit | ||
| if limit == 0 { | ||
| newLimit = uint32(10) |
There was a problem hiding this comment.
wouldn't be better this to be a constant instead of hardcoded uint32(10)?
There was a problem hiding this comment.
done, i'd use constant.ReceiptBatchMaximum it is uint32 @iltoga in the commit below.
andy-shi88
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
batch_receipt, incoming receipt will store intobatch_receiptbefore the count of batch_receipt collection >=ReceiptBatchMaximum.merkle_rootincludedrootandtreenode_receiptif count of it is >=ReceiptBatchMaximum.Breakdown
batch_receiptnode_receiptcollection storedReference Issue
Close #202
Refered zoobc/zoobc-schema#62
Step to Test (optional)
go test ./...