254 block receipts reminder #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…receipts-reminder
andy-shi88
requested review from
iltoga,
astaphobia,
capt4ce,
sukrawidhyawan and
komodo2662
iltoga
approved these changes
Oct 2, 2019
| Insert(key string, value []byte, expiry int) error | ||
| BatchInsert(updates map[string][]byte) error | ||
| Get(key string) ([]byte, error) | ||
| GetByPrefix(prefix string) (map[string][]byte, error) |
There was a problem hiding this comment.
It would be useful also having Delete BatchDelete/Trim and functions.
maybe in the next PR?..
There was a problem hiding this comment.
yes will be useful, but I don't have any clue on the possible usage yet, too afraid to create function signature that might not satisfy our needs later, will note this for later implementation
komodo2662
approved these changes
Oct 3, 2019
sukrawidhyawan
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add block receipt reminder and receipt generator validation.
+BadgerDB integration (key-value)
Breakdown
kvdbnode+dataReference Issue
Close #254
Close #282
Step to Test (optional)