Skip to content

Conversation

andy-shi88
Copy link
Contributor

Description

Block Creation (Smithing) process in play.

Breakdown

  • Port prototype smithing process
  • Integrate block pushed to the database
  • new executor method ExecuteStatements that will be mostly used for update or create query.
  • update api/blockService to fix minor bug (unimplemented interface, update test)
  • update root.readme
  • connect blocksmith to account_balance *will have to wait until tx or account integrated: ignore this for now
  • genesis transaction *will have to wait until txs ready: ignore this for now
  • block signature *put this on another issue.

Reference Issue

Close #5

Step to Test (optional)

  • ensure all deps installed dep ensure -v
  • to run: go run main.go
  • build and run: go build -o main && ./main
  • run all tests, go test ./...

@andy-shi88 andy-shi88 added the FEATURE New feature or request label Jul 8, 2019
@andy-shi88 andy-shi88 self-assigned this Jul 8, 2019
Copy link
Contributor

@iltoga iltoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only minor optional name refactoring in VerifySeed and GetSmithTime where there are references to terms such as baseTarget and staticTarget, not part of our Lexicon

@andy-shi88
Copy link
Contributor Author

noted, updating it now 👍 , but I'll leave staticTarget for now until got the better word for it,

@astaphobia astaphobia added this to the Sprint 1 milestone Jul 9, 2019
@astaphobia astaphobia merged commit 0b1af0d into develop Jul 9, 2019
@astaphobia astaphobia deleted the 5-block-creation branch July 9, 2019 08:02
@andy-shi88 andy-shi88 removed their assignment Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech:Block Creation
4 participants