Skip to content

#305 minor fix: move missing database transaction initialization #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2019
Merged

#305 minor fix: move missing database transaction initialization #306

merged 3 commits into from
Oct 8, 2019
+8 −6

Conversation

andy-shi88
Copy link
Contributor

Description

Fix db transaction initialization in mempool expiration process.

Breakdown

  • move db.BeginTx code to cover the whole operation of mempool expiration

Reference Issue

Close #305

Sorry, something went wrong.

@andy-shi88 andy-shi88 self-assigned this Oct 4, 2019
@andy-shi88 andy-shi88 added the BUG Something isn't working label Oct 4, 2019
iltoga
iltoga approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@iltoga iltoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch man

@iltoga iltoga self-requested a review October 8, 2019 01:09
@astaphobia astaphobia merged commit da70b6e into zoobc:develop Oct 8, 2019
@astaphobia astaphobia deleted the 305-mempool-expiration-db-bug branch October 8, 2019 06:07
@andy-shi88 andy-shi88 removed their assignment Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astaphobia astaphobia

@capt4ce capt4ce

@iltoga iltoga

Assignees
No one assigned
Labels
BUG Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Mempool Expiration Nil Pointer
4 participants
@andy-shi88 @iltoga @astaphobia @capt4ce