Skip to content

31 block signature #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 10, 2019
Merged

31 block signature #37

merged 5 commits into from
Jul 10, 2019

Conversation

andy-shi88
Copy link
Contributor

Description

A brief description of the pull request.

Breakdown

  • Add Signature object to handle different signature
  • integrate block signature
  • Update NewBlocksmith to accept secretPhrase and build node and account information from that later.
  • modify getBlockByte helper to be able to turn on sign in the block. sign will indicate wether we want to include a signature or not in the byte.

Reference Issue

Close #31

Step to Test (optional)

  • go run main.go will still run the block creation as it did, but with block signature this time.

@andy-shi88 andy-shi88 self-assigned this Jul 10, 2019
@andy-shi88 andy-shi88 requested review from hardisp and komodo2662 July 10, 2019 02:29
Copy link
Contributor

@capt4ce capt4ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@capt4ce capt4ce merged commit ddacb21 into develop Jul 10, 2019
@capt4ce capt4ce deleted the 31-block-signature branch July 10, 2019 03:22
@andy-shi88 andy-shi88 removed their assignment Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech: Block Signature
4 participants