393 mempool rollback step backup mempool transactions into badgerdb #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astaphobia
requested review from
iltoga,
capt4ce,
andy-shi88,
sukrawidhyawan and
komodo2662
andy-shi88
reviewed
Nov 5, 2019
andy-shi88
approved these changes
Nov 6, 2019
sukrawidhyawan
approved these changes
Nov 6, 2019
andy-shi88
approved these changes
Nov 7, 2019
sukrawidhyawan
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mempool need to have BlockQuery to get
current LastBlock.Heightthat should own by mempool transactions which want to backup to badgerdb. In my side i have to use blockQuery instead ofBlockService.GetLastBlock()because that can got error cycle import while BlockService have MempoolService as wellReference Issue
Close #393 step 1
Depend on zoobc/zoobc-schema#72
Step to Test (optional)