398 387 refactor and expose node scrambling and priority peers #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capt4ce
requested review from
iltoga,
astaphobia,
andy-shi88 and
sukrawidhyawan
…pose-node-scrambling-and-priority-peers
2 tasks
andy-shi88
approved these changes
Nov 7, 2019
capt4ce
changed the title
sukrawidhyawan
approved these changes
Nov 7, 2019
…pose-node-scrambling-and-priority-peers
andy-shi88
deleted the
398-387-expose-node-scrambling-and-priority-peers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring
Node Scramblingmechanism so that the data can be used across services. Also exposing ScrambledNodes of the host to the API call GetHostInfo.when requested with testing framework. The ScrambledNodes also included in the response:
Breakdown
BuildScrambledNodesto NodeRegistrationServiceGetScrambledNodesin NodeRegistrationServicePriorityStrategyto use functions related to Scrambled nodes from NodeRegistrationServiceScrambledNodesandScrambledNodesHeightof the host to the API callGetHostInfo.requires zoobc/zoobc-schema#73
Reference Issue
Close #398 #387
Step to Test (optional)
go test ./...