Skip to content

6 transaction implementation #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 11, 2019
Merged

6 transaction implementation #43

merged 6 commits into from
Jul 11, 2019

Conversation

andy-shi88
Copy link
Contributor

Description

Breakdown

  • Parse and Get transaction bytes
  • Executor to be able to execute multiple statements

Reference Issue

part of #6

Step to Test (optional)

  • run go test ./...

@andy-shi88 andy-shi88 requested review from astaphobia and capt4ce July 11, 2019 02:35
@andy-shi88 andy-shi88 self-assigned this Jul 11, 2019
@andy-shi88 andy-shi88 added the FEATURE New feature or request label Jul 11, 2019
@andy-shi88 andy-shi88 added this to the Sprint 1 milestone Jul 11, 2019
@andy-shi88
Copy link
Contributor Author

WIP: forget to handle no-recipient

capt4ce
capt4ce approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@capt4ce capt4ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@capt4ce capt4ce merged commit 9b04f93 into develop Jul 11, 2019
@capt4ce capt4ce deleted the 6-transaction-implementation branch July 11, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astaphobia astaphobia astaphobia approved these changes

@capt4ce capt4ce capt4ce approved these changes

Assignees
No one assigned
Labels
FEATURE New feature or request
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.
3 participants
@andy-shi88 @astaphobia @capt4ce