Skip to content

Changing the block Api parameter #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2019
Merged

Changing the block Api parameter #59

merged 2 commits into from
Jul 13, 2019

Conversation

capt4ce
Copy link
Contributor

@capt4ce capt4ce commented Jul 13, 2019 •
edited
Loading

Description

Changing the parameters in the block API requests.

Breakdown

  • Changing BlockHeight to Height
  • Changing BlockSize in the GetBlocksRequest request to Limit
  • Changing BlockSize in the GetBlocksResponse request to Count
  • Making adjustment in the code for the change in the parameter
  • Making adjustment in the tests

Reference Issue

Close #58

Step to Test (optional)

@capt4ce capt4ce self-assigned this Jul 13, 2019
@capt4ce capt4ce added the FEATURE New feature or request label Jul 13, 2019
@astaphobia astaphobia merged commit 13adcdb into develop Jul 13, 2019
@capt4ce capt4ce deleted the 58-change-block-api branch July 13, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iltoga iltoga Awaiting requested review from iltoga

2 more reviewers

@astaphobia astaphobia astaphobia approved these changes

@andy-shi88 andy-shi88 andy-shi88 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@capt4ce capt4ce

Labels
FEATURE New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tech: Changing block API structure
3 participants
@capt4ce @astaphobia @andy-shi88