Skip to content

Fixed transaction generator affected by fee #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2020
+10 −6
Merged

Fixed transaction generator affected by fee #611

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf6521b
no need to validate current block height
astaphobia Feb 26, 2020
3efe15b
Merge branch 'develop' of github.com:zoobc/zoobc-core into develop
astaphobia Feb 26, 2020
f634da4
fixed transcation generator afftected by fee
astaphobia Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions cmd/transaction/generator.go
View file
Original file line number Diff line number Diff line change
@@ -226,10 +226,8 @@ func GenerateTxRemoveAccountDataset(
return tx
}

/*
Basic Func
*/
func GenerateBasicTransaction(senderSeed string,
func GenerateBasicTransaction(
senderSeed string,
version uint32,
timestamp, fee int64,
recipientAccountAddress string,
@@ -268,15 +266,21 @@ func PrintTx(signedTxBytes []byte, outputType string) {
}

func GenerateSignedTxBytes(tx *model.Transaction, senderSeed string) []byte {
var transactionUtil = &transaction.Util{}
var (
transactionUtil = &transaction.Util{}
txType transaction.TypeAction
)
txType, _ = (&transaction.TypeSwitcher{}).GetTransactionType(tx)
minimumFee, _ := txType.GetMinimumFee()
tx.Fee += minimumFee

unsignedTxBytes, _ := transactionUtil.GetTransactionBytes(tx, false)
tx.Signature = signature.Sign(
unsignedTxBytes,
constant.SignatureTypeDefault,
senderSeed,
)
signedTxBytes, _ := transactionUtil.GetTransactionBytes(tx, true)
fmt.Printf("signedBytes: %v\n", len(signedTxBytes))
return signedTxBytes
}