Skip to content

throw error on over limit get blocks #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2020
Merged

throw error on over limit get blocks #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
488cb2a
throw error on over limit get blocks
nawikart Mar 20, 2020
af327b6
move limit validation to handler layer
nawikart Mar 23, 2020
54798d6
Merge branch 'develop' into GetBlocks-Limit
andy-shi88 Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api/handler/blockHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@ package handler

import (
"context"
"fmt"

"github.com/zoobc/zoobc-core/api/service"
"github.com/zoobc/zoobc-core/common/constant"
"github.com/zoobc/zoobc-core/common/chaintype"
"github.com/zoobc/zoobc-core/common/model"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)

// BlockHandler to handle request related to Blocks from client
Expand Down Expand Up @@ -35,6 +39,10 @@ func (bs *BlockHandler) GetBlock(ctx context.Context, req *model.GetBlockRequest

// GetBlocks handles request to get data of multiple blocks
func (bs *BlockHandler) GetBlocks(ctx context.Context, req *model.GetBlocksRequest) (*model.GetBlocksResponse, error) {
if req.Limit > constant.MaxAPIGetBlocks {
return nil, status.Error(codes.OutOfRange, fmt.Sprintf("limit exceeded, max. %d", constant.MaxAPIGetBlocks))
}

chainType := chaintype.GetChainType(req.ChainType)
blocksResponse, err := bs.Service.GetBlocks(chainType, req.Limit, req.Height)
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions common/constant/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ package constant

var (
MaxAPIRequestPerSecond uint32 = 10
MaxAPIGetBlocks uint32 = 500
)