Bug fixes, golangci-lint update version

.circleci/config.yml

@@ -3,6 +3,19 @@ defaults: &defaults
     working_directory: ~/zoobc
     docker:
         - image: circleci/golang:1.14.0-stretch
+reset_dbs: &reset_dbs
+    name: RESET DBs
+    command: |
+        if [[ ${CIRCLE_BRANCH} == *"reset-db"* ]]; then
+          for host in $ln1 $ln2 $ln3; do ssh root@$host 'for f in *.db; do mv -- "$f" "_$f"; done'; done
+        fi
+reset_db: &reset_db
+    name: RESET DB
+    command: |
+        if [[ ${CIRCLE_BRANCH} == *"reset-db"* ]]; then
+          ssh root@$ln4 'for f in *.db; do mv -- "$f" "_$f"; done';
+        fi
+
 jobs:
     prepare:
         <<: *defaults
@@ -96,6 +109,7 @@ jobs:
                   name: DOWN SERVICES
                   command: |
                       for host in $ln1 $ln2 $ln3; do ssh root@$host 'sudo systemctl stop zoobc.service'; done
+            - run: *reset_dbs
             - run:
                   name: DEPLOY
                   command: |
@@ -127,6 +141,7 @@ jobs:
                   name: DOWN SERVICE
                   command: |
                       ssh root@$ln4 'sudo systemctl stop zoobc.service'
+            - run: *reset_db
             - run:
                   name: DEPLOY APP
                   command: |

.golangci.yml

@@ -36,7 +36,7 @@ linters-settings:
             - zoobc
             - multisig
     lll:
-        line-length: 140
+        line-length: 150
     goimports:
         local-prefixes: github.com/zoobc/zoobc-core
     gocritic:
@@ -52,6 +52,7 @@ linters-settings:
             - dupImport # https://github.com/go-critic/go-critic/issues/845
             - exitAfterDefer
             - importShadow
+            - appendAssign
     funlen:
         l: 50
         s: 55
@@ -65,6 +66,7 @@ linters:
         - gochecknoglobals
         - gochecknoinits
         - gocognit
+        - ineffassign
     fast: false
 run:
     skip-dirs:
@@ -124,6 +126,9 @@ issues:
         - text: "G202: SQL string concatenation"
           linters:
               - gosec
+        - text: "G108: Profiling endpoint is automatically exposed on /debug/pprof"
+          linters:
+              - gosec
         - text: "is too long"
           linters:
               - funlen

Makefile

@@ -1,6 +1,6 @@
 BIN_DIR := $(GOPATH)/bin
 GOLANGCILINT := $(BIN_DIR)/golangci-lint
-GOLANGCILINT_VERSION := v1.20.0
+GOLANGCILINT_VERSION := v1.23.8
 XGO := $(BIN_DIR)/xgo
 VERSION ?= latest
 BINARY_CORE := zoobc
@@ -23,7 +23,7 @@ $(XGO):
 .PHONY: golangci-lint
 golangci-lint: $(GOLANGCILINT)
 	$(info    running linter...)
-	golangci-lint run
+	golangci-lint run --timeout=20m -v
 
 .PHONY: go-fmt
 go-fmt:

api/handler/multisigHandler.go

@@ -3,10 +3,12 @@ package handler
 import (
 	"context"
 
-	"github.com/zoobc/zoobc-core/api/service"
-	"github.com/zoobc/zoobc-core/common/model"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
+
+	"github.com/zoobc/zoobc-core/api/service"
+
+	"github.com/zoobc/zoobc-core/common/model"
 )
 
 type (

api/service/multisigService.go

@@ -4,8 +4,10 @@ import (
 	"database/sql"
 	"encoding/hex"
 
-	"github.com/sirupsen/logrus"
 	"github.com/zoobc/zoobc-core/common/constant"
+
+	"github.com/sirupsen/logrus"
+
 	"github.com/zoobc/zoobc-core/common/model"
 	"github.com/zoobc/zoobc-core/common/query"
 	coreService "github.com/zoobc/zoobc-core/core/service"

cmd/readme.md

@@ -143,3 +143,13 @@ go run main.go generate poow --node-seed "concur vocalist rotten busload gap quo
 ```bash
 go run main.go rollback blockchain --to-height 10 --db-path "../resource" --db-name "zoobc.db"
 ```
+
+### Signature Signing data using Ed25519
+```bash
+go run main.go signature sign ed25519 --data-bytes='1, 222, 54, 12, 32' --use-slip10=true
+```
+
+### Signature Verifying data
+```bash
+go run main.go signature verify --data-bytes='1, 222, 54, 12, 32' --signature-hex=0000000063851d61318eaf923ff72457fd9b5716db9904aacbe53eb1bc25cd8a7bf2816c61402b0c52d4324e1336bae4ea28194d6f5c531292fd266e63a293519f20c20b --account-address=WI-u0jyKMGsPHk6K7eT1Utnxc6WiKehkIEs87Zf3fIsH
+```

cmd/signature/cmd.go

@@ -12,58 +12,185 @@ import (
 	"golang.org/x/crypto/sha3"
 )
 
+type (
+	// GeneratorCommands represent struct of signature generator commands
+	GeneratorCommands struct {
+		Signature crypto.SignatureInterface
+	}
+)
+
 var (
+	signatureCmdInstance *GeneratorCommands
 	/*
 		Signer command line tools
 	*/
+	signatureCmd = &cobra.Command{
+		Use:   "signature",
+		Short: "signature command is a parent command for signature stuffs",
+	}
 	signerCmd = &cobra.Command{
 		Use:   "sign",
 		Short: "sign provided data",
 		Long:  "sign any provided data by using the --seed parameter",
 	}
+
+	ed25519SignerCmd = &cobra.Command{
+		Use:   "ed25519",
+		Short: "sign using ed25519 algoritmn",
+		Long:  "sign any provided data by using the --seed parameter",
+	}
+
+	verifyCmd = &cobra.Command{
+		Use:   "verify",
+		Short: "verify provided signature ",
+		Long:  "verify provided signature against provided data using public key",
+	}
 )
 
 func init() {
-	signerCmd.Flags().StringVar(&dataHex, "data-hex", "", "hex string of the data to sign")
-	signerCmd.Flags().StringVar(&dataBytes, "data-bytes", "", "data bytes separated by `, `. eg:"+
+	signatureCmd.PersistentFlags().StringVar(&dataHex, "data-hex", "", "hex string of the data to sign")
+	signatureCmd.PersistentFlags().StringVar(&dataBytes, "data-bytes", "", "data bytes separated by `, `. eg:"+
 		"--data-bytes='1, 222, 54, 12, 32'")
-	signerCmd.Flags().StringVar(&seed, "seed", "", "your secret phrase")
-	signerCmd.Flags().BoolVar(&hash, "hash", false, "turn this flag on to hash the data before signing")
+
+	signerCmd.PersistentFlags().StringVar(&seed, "seed", "", "your secret phrase")
+	signerCmd.PersistentFlags().BoolVar(&hash, "hash", false, "turn this flag on to hash the data before signing")
+	ed25519SignerCmd.Flags().BoolVar(&ed25519UseSlip10, "use-slip10", false, "use slip10 to generate ed25519 private key for signing")
+
+	verifyCmd.Flags().StringVar(&signatureHex, "signature-hex", "", "hex string of the signature")
+	verifyCmd.Flags().StringVar(&signatureBytes, "signature-bytes", "", "signature bytes stseparated by `, `. eg:"+
+		"--signature-bytes='1, 222, 54, 12, 32'")
+	verifyCmd.Flags().StringVar(&accountAddress, "account-address", "", "the address who sign the data")
+
 }
 
+// Commands return main command of signature
 func Commands() *cobra.Command {
-	signerCmd.Run = SignData
-	return signerCmd
+	if signatureCmdInstance == nil {
+		signatureCmdInstance = &GeneratorCommands{
+			Signature: &crypto.Signature{},
+		}
+	}
+	ed25519SignerCmd.Run = signatureCmdInstance.SignEd25519
+	signerCmd.AddCommand(ed25519SignerCmd)
+	signerCmd.Run = signatureCmdInstance.SignEd25519
+	signatureCmd.AddCommand(signerCmd)
+
+	verifyCmd.Run = signatureCmdInstance.VerySignature
+	signatureCmd.AddCommand(verifyCmd)
+	return signatureCmd
 }
 
-func SignData(*cobra.Command, []string) {
+// SignEd25519 is sign command handler using Ed25519 algorithm
+func (gc *GeneratorCommands) SignEd25519(*cobra.Command, []string) {
 	var (
 		unsignedBytes       []byte
 		hashedUnsignedBytes [32]byte
+		accountAddress      string
 		signature           []byte
+		err                 error
 	)
+
 	if dataHex != "" {
-		unsignedBytes, _ = hex.DecodeString(dataHex)
+		unsignedBytes, err = hex.DecodeString(dataHex)
+		if err != nil {
+			panic("failed to decode data hex")
+		}
 	} else {
-		txByteCharSlice := strings.Split(dataBytes, ", ")
-		for _, v := range txByteCharSlice {
-			byteValue, err := strconv.Atoi(v)
-			if err != nil {
-				panic("failed to parse transaction bytes")
-			}
-			unsignedBytes = append(unsignedBytes, byte(byteValue))
+		unsignedBytes, err = parseBytesArgs(dataBytes, ", ")
+		if err != nil {
+			panic("failed to parse data bytes")
 		}
 	}
+	_, _, _, accountAddress, err = gc.Signature.GenerateAccountFromSeed(
+		model.SignatureType_DefaultSignature,
+		seed,
+		ed25519UseSlip10,
+	)
+	if err != nil {
+		panic(err.Error())
+	}
 	if hash {
 		hashedUnsignedBytes = sha3.Sum256(unsignedBytes)
-		signature, _ = (&crypto.Signature{}).Sign(hashedUnsignedBytes[:], model.SignatureType_DefaultSignature, seed)
-	} else {
-		signature, _ = (&crypto.Signature{}).Sign(unsignedBytes, model.SignatureType_DefaultSignature, seed)
+		unsignedBytes = hashedUnsignedBytes[:]
+	}
+	signature, err = gc.Signature.Sign(
+		unsignedBytes,
+		model.SignatureType_DefaultSignature,
+		seed,
+		ed25519UseSlip10,
+	)
+	if err != nil {
+		panic(err.Error())
 	}
-	edUtil := crypto.NewEd25519Signature()
-	fmt.Printf("account-address:\t%v\n", edUtil.GetAddressFromSeed(seed))
+
+	fmt.Printf("account-address:\t%v\n", accountAddress)
 	fmt.Printf("transaction-bytes:\t%v\n", unsignedBytes)
 	fmt.Printf("transaction-hash:\t%v\n", hex.EncodeToString(hashedUnsignedBytes[:]))
 	fmt.Printf("signature-bytes:\t%v\n", signature)
 	fmt.Printf("signature-hex:\t%v\n", hex.EncodeToString(signature))
 }
+
+// VerySignature is verify signature command hendler
+func (gc *GeneratorCommands) VerySignature(*cobra.Command, []string) {
+	var (
+		unsignedBytes     []byte
+		signature         []byte
+		failedVerifyCause = "none"
+		isVerified        = true
+		err               error
+	)
+	if dataHex != "" {
+		unsignedBytes, err = hex.DecodeString(dataHex)
+		if err != nil {
+			panic("failed to decode data hex")
+		}
+	} else {
+		unsignedBytes, err = parseBytesArgs(dataBytes, ", ")
+		if err != nil {
+			panic("failed to parse data bytes")
+		}
+	}
+
+	if signatureHex != "" {
+		signature, err = hex.DecodeString(signatureHex)
+		if err != nil {
+			panic("failed to decode signature hex")
+		}
+	} else {
+		signature, err = parseBytesArgs(signatureBytes, ", ")
+		if err != nil {
+			panic("failed to parse data bytes")
+		}
+	}
+
+	err = gc.Signature.VerifySignature(unsignedBytes, signature, accountAddress)
+	if err != nil {
+		failedVerifyCause = err.Error()
+		isVerified = false
+	}
+
+	fmt.Printf("verify-status:\t%v\n", isVerified)
+	fmt.Printf("failed-causes:\t%v\n", failedVerifyCause)
+	fmt.Printf("address:\t%v\n", accountAddress)
+	fmt.Printf("payload-bytes:\t%v\n", unsignedBytes)
+	fmt.Printf("payload-hex:\t%v\n", hex.EncodeToString(unsignedBytes))
+
+	fmt.Printf("signature-hex:\t%v\n", hex.EncodeToString(signature))
+	fmt.Printf("signature-bytes:%v\n", signature)
+
+}
+
+func parseBytesArgs(argsBytesString, separated string) ([]byte, error) {
+	var (
+		parsedByte    []byte
+		byteCharSlice = strings.Split(argsBytesString, separated)
+	)
+	for _, v := range byteCharSlice {
+		byteValue, err := strconv.Atoi(v)
+		if err != nil {
+			return nil, err
+		}
+		parsedByte = append(parsedByte, byte(byteValue))
+	}
+	return parsedByte, nil
+}

cmd/signature/const.go

@@ -1,8 +1,15 @@
 package signature
 
 var (
-	seed      string
-	dataHex   string
-	dataBytes string
-	hash      bool
+	// sign
+	seed             string
+	dataHex          string
+	dataBytes        string
+	hash             bool
+	ed25519UseSlip10 bool
+
+	// verify
+	signatureBytes string
+	signatureHex   string
+	accountAddress string
 )