Skip to content

Confirm the state of download finish if the whole network stuck #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Confirm the state of download finish if the whole network stuck #770

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03b0655
confirm the state of download finish if the whole network stuck
capt4ce Apr 22, 2020
1d33795
reset the firstDownloadCounter when finding out they are not stuck
capt4ce Apr 22, 2020
ec116e4
reduce the validation limit constant
capt4ce Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/blockchainsync/downloadBlockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ type (
PeerExplorer strategy.PeerExplorerStrategyInterface
Logger *log.Logger
BlockchainStatusService service.BlockchainStatusServiceInterface
firstDownloadCounter int32
}

PeerBlockchainInfo struct {
Expand Down Expand Up @@ -75,10 +76,20 @@ func (bd *BlockchainDownloader) IsDownloadFinish(currentLastBlock *model.Block)
return false
}
heightAfterDownload := afterDownloadLastBlock.Height
// to avoid the network being start at the initial kick off / restart
if currentHeight == heightAfterDownload {
bd.firstDownloadCounter++
if bd.firstDownloadCounter >= constant.MaxResolvedPeers {
bd.firstDownloadCounter = 0
return true
}
}
cumulativeDifficultyAfterDownload := afterDownloadLastBlock.CumulativeDifficulty
if currentHeight > 0 && currentHeight == heightAfterDownload && currentCumulativeDifficulty == cumulativeDifficultyAfterDownload {
bd.firstDownloadCounter = 0
return true
}
bd.firstDownloadCounter = 0
return false
}

Expand Down