40 post transaction #96
Conversation
andy-shi88
requested review from
iltoga,
astaphobia,
capt4ce,
sukrawidhyawan and
komodo2662
api/api.go
Outdated
| @@ -4,6 +4,12 @@ import ( | |||
| "fmt" | |||
| "net" | |||
|
|
|||
| "github.com/zoobc/zoobc-core/common/chaintype" | |||
| service2 "github.com/zoobc/zoobc-core/core/service" | |||
cmd/main.go
Outdated
| @@ -3,12 +3,15 @@ package main | |||
| import ( | |||
| "github.com/spf13/cobra" | |||
| "github.com/zoobc/zoobc-core/cmd/account" | |||
| "github.com/zoobc/zoobc-core/cmd/transaction" | |||
| "github.com/zoobc/zoobc-core/common/crypto" | |||
| "github.com/zoobc/zoobc-core/common/util" | |||
| ) | |||
|
|
|||
| func main() { | |||
| var rootCmd = &cobra.Command{Use: "zoobc"} | |||
| logger, _ := util.InitLogger(".log/", "debug.log") | |||
There was a problem hiding this comment.
need to save log file with the specific name, like cmd.log or cmd.debug.log
| @@ -28,6 +28,7 @@ func (m *Migration) Init() error { | |||
| if m.Query != nil { | |||
| rows, _ := m.Query.ExecuteSelect("SELECT version FROM migration;") | |||
| if rows != nil { | |||
| defer rows.Close() | |||
There was a problem hiding this comment.
not sure defer will be trigger even if rows is nil
There was a problem hiding this comment.
tested, it won't it will only defer when row != nil proofed by no panick, since if it's nil, calling row.Close() would result in panic.
| var ( | ||
| recipientAccount model.Account | ||
| senderAccount model.Account | ||
| err error | ||
| ) | ||
|
|
||
| if tx.Height > 0 { |
There was a problem hiding this comment.
if tx.Validate() got error need to UndoApplyUnconfirmed() or not ??
There was a problem hiding this comment.
need to check on this one, since mempool is executing validate function on get transaction, I'm not sure if I should keep validation inside ApplyConfirmed or the other way, let me think
There was a problem hiding this comment.
you're right, if validate fail, should not do undo. Updated in newest commit.
|
updated, please check 👍 @capt4ce @astaphobia |
|
wip, need to check the validate function |
api/client/PostTransaction/client.go
Outdated
| c := rpc_service.NewTransactionServiceClient(conn) | ||
|
|
||
| response, err := c.PostTransaction(context.Background(), &rpc_model.PostTransactionRequest{ | ||
| // TransactionBytes: []byte{ |
There was a problem hiding this comment.
Is it still of any useful? otherwise I think we should remove it, what do you think?
Description
Open
post-transactionrpc endpoint.Breakdown
post-transactionendpointVEThandling for account-balanceReference Issue
Close #40
Step to Test (optional)
go run main.gogo run api/client/PostTransaction/client.go