Skip to content

Fix manifest rollback #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Fix manifest rollback #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c4e69
add spine_block_height to enable manifest rollback
andy-shi88 Apr 21, 2020
36246d2
Merge branch 'develop' of github.com:zoobc/zoobc-schema into fix-mani…
andy-shi88 Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions documentation.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2423,10 +2423,15 @@
"format": "int64",
"title": "ID computed as the little endian of the spineBlockManifest hash (hash of all spineBlockManifest fields but the ID)"
},
"SpineBlockManifestHeight": {
"ManifestReferenceHeight": {
"type": "integer",
"format": "int64",
"title": "SpineBlockManifestHeight height (on the mainchain) at which the (snapshot) file started been computed\nNote: this is not the last mainchain height contained in the snapshot file (that one should be = SpineBlockManifestHeight - MinRollbackBlocks)"
"title": "ManifestReferenceHeight height (on the mainchain) at which the (snapshot) file started been computed\nNote: this is not the last mainchain height contained in the snapshot file (that one should be = SpineBlockManifestHeight - MinRollbackBlocks)"
},
"ManifestSpineBlockHeight": {
"description": "ManifestSpineBlockHeight (on spinechain) at which the (manifest) got included in the block, this data\nis tightly coupled to the spine block.",
"type": "integer",
"format": "int64"
},
"SpineBlockManifestType": {
"title": "SpineBlockManifestType type of spineBlockManifest",
Expand Down
13 changes: 8 additions & 5 deletions model/spineBlockManifest.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,18 @@ message SpineBlockManifest {
bytes FullFileHash = 2;
// FileChunkHashes sequence of hashes (sha256 = 32 byte) of file chunks (sorted) referenced by the spineBlockManifest
bytes FileChunkHashes = 3;
// SpineBlockManifestHeight height (on the mainchain) at which the (snapshot) file started been computed
// ManifestReferenceHeight height (on the mainchain) at which the (snapshot) file started been computed
// Note: this is not the last mainchain height contained in the snapshot file (that one should be = SpineBlockManifestHeight - MinRollbackBlocks)
uint32 SpineBlockManifestHeight = 4;
uint32 ManifestReferenceHeight = 4;
// ManifestSpineBlockHeight (on spinechain) at which the (manifest) got included in the block, this data
// is tightly coupled to the spine block.
uint32 ManifestSpineBlockHeight = 5;
// Number indicating chaintype (at the moment it can only be mainchain, but in future could be others)
int32 ChainType = 5;
int32 ChainType = 6;
// SpineBlockManifestType type of spineBlockManifest
SpineBlockManifestType SpineBlockManifestType = 6;
SpineBlockManifestType SpineBlockManifestType = 7;
// ExpirationTimestamp timestamp that marks the end of spineBlockManifest processing
int64 ExpirationTimestamp = 7;
int64 ExpirationTimestamp = 8;
}

// SpineBlockManifestType type of spineBlockManifest (as of now only snapshot)
Expand Down