Widget binding ignores are breaking hchbaw/opp.zsh

[zhimsel]

If I use both zsh-syntax-highlighting and opp.zsh, opp produces an error whenever a new shell is started:

(eval):1: bad pattern: orig-opp-gps-( opp-gps-(
(eval):1: parse error near `)'
(eval):1: parse error near `;'
(eval):1: parse error near `;'
(eval):1: bad pattern: orig-opp-gps-[
(eval):1: parse error near `}'

I was able to narrow it down to zsh-syntax-highlighting, and discovered this behavior was introduced in 18df692. The previous commit (7044c19) works fine.

My zshrc is available here: https://github.com/zhimsel/dotfiles/blob/master/zshrc
That should be current and live on my machine.

[zhimsel]

Upon further digging, it looks like specifically 487b122 is the culprit. If I revert that specific commit, the error is not produced.

[danielshahaf]

@m0vie It's your patch, could you have a look?

@zhimsel Could you please try to reproduce the problem in zsh -f followed by source .../opp.zsh; source ../zsh-syntax-highlighting.zsh?

[danielshahaf]

I guess we need either to get rid of the eval, or to use ${(q)} or ${(b)}. (in a way that's backwards-compatible to older zsh's)

[zhimsel]

@danielshahaf:

$ zsh -f
% source opp/opp.zsh
% source zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
% 

Seems to work.

[zhimsel]

Correction, it does not. Sorry, I was using the wrong commit. Same error when using master/HEAD:

$ zsh -f
% source opp/opp.zsh
% source zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
(eval):1: bad pattern: orig-opp-gps-( opp-gps-(
(eval):1: parse error near `)'
(eval):1: parse error near `;'
(eval):1: parse error near `;'
(eval):1: bad pattern: orig-opp-gps-[
(eval):1: parse error near `}'
%

[danielshahaf]

@zhimsel Should be fixed in latest master; apologies for the delay.

@m0vie I'm a bit unsatisfied at having had to fix a bug introduced by a colleague; normally people should fix their own bugs. I guess you were going to look into it over the upcoming weekend, though?

[zhimsel]

@danielshahaf upon updating master, and launching a new shell I get the following:

_zsh_highlight_bind_widgets:zle:24: not enough arguments for -C
_zsh_highlight_bind_widgets:zle:24: not enough arguments for -C
_zsh_highlight_bind_widgets:zle:24: not enough arguments for -C
<repeated a bunch>
10:23:54 zach at randir in ~/dotfiles/zsh/zsh-syntax-highlighting
$
No such widget `orig-'

I also cannot enter text on the prompt. Line editing is not permitted at all.

[danielshahaf]

make test didn't catch this :(

[danielshahaf]

Fixed the breakage. Currently the opp.zsh issue has resurfaced, will fix that later.