No highlighting while cycling menu completion results #375
Description
While cycling through results in menu completion, no highlighting is applied:
-
No widget is called for current
masterbranch. -
zle-line-pre-redrawis not called, either.
Not sure about 1), but 2) can probably be fixed by introducing another redrawhook(); in upstream.
Activity
danielshahaf commentedon Oct 16, 2016
Patch upstream: workers/39590
danielshahaf commentedon Oct 19, 2016
Committed upstream in zsh-users/zsh@5b192a4. @m0vie, I assume we can close this issue, unless there is a z-sy-h side fix that can be done to support older zsh's?
danielshahaf commentedon Oct 19, 2016
(To be clear: the upstream patch fixes this issue.)
m0vie commentedon Oct 19, 2016
Yes, I don't think there is anything we can do to make it work with older versions.
ratheesh commentedon Jun 1, 2017
I still observe this issue in zsh v.5.3.1. Can somebody confirm if this is fixed in latest zsh.
danielshahaf commentedon Jun 1, 2017
@ratheesh Yes, it's fixed in latest zsh.
ratheesh commentedon Jun 2, 2017
If I enable menu select using
zstyle ':completion:*:*:*:*:*' menu select,the functionality breaks. Is this expected?
Is there a setting or workaround to get this working?
danielshahaf commentedon Jun 2, 2017
ratheesh commentedon Jun 3, 2017
@danielshahaf
I am using 5.3.1. But I also tried the latest master(a6135f6) branch. I still see this issue.
I tried zstyle config that you mentioned, I did not see any difference.
danielshahaf commentedon Jun 3, 2017
Reopening per @ratheesh's last comment. @ALL Can somebody investigate this?
danielshahaf commentedon Jun 3, 2017
(Sorry for shouting. I typed "all" in lowercase; I think it's a github bug.)
6 remaining items
ratheesh commentedon Aug 13, 2017
Just to add,
z-sy-hfeature/redrawhookbranch breaks zsh-autosuggestions plugin highlighting.ratheesh commentedon Sep 12, 2017
may I know if any got a chance look into this.
danielshahaf commentedon Sep 14, 2017
Sorry, missed your comments.
Okay; labeled as such and added to the list in #245. Hopefully redrawhook will be merged for 0.7.0 so this will be fixed then.
Please test with latest master of both and if it's still a problem, open a new issue. Thanks!
ColemanGariety commentedon Apr 11, 2020
I'm experiencing this, which has been an issue for nine years, wow (#25)! What's the latest fix?
danielshahaf commentedon Apr 11, 2020
Will be fixed when redrawhook is fixed, hopefully soon. In the meantime you can workaround this by using (or merging) the
feature/redrawhookbranch.nhooyr commentedon May 26, 2020
@danielshahaf Why isn't that branch just merged into master?
I'm seeing this in latest zsh 5.8 from homebrew.
danielshahaf commentedon May 26, 2020
Because it causes a regression in a certain class of use-cases (see #418 and #579) and we're trying to figure out how to solve that regression without making a change to zsh itself (zsh-users/zsh#57), waiting for the next zsh release, and requiring all users to upgrade to that.
nhooyr commentedon May 26, 2020
Awesome, thanks for responding!
nhooyr commentedon Aug 9, 2020
🎉🎉
Congrats guys!
danielshahaf commentedon Aug 10, 2020
Thanks :-)
empty commit: Close redrawhook bugs