Skip to content

Global aliases cause performance regression #728

@danielshahaf

Description

@danielshahaf
Member

I've compared the performance of 0.7.1 and current master (343ec10) using the make perf tool added in the referenced commit. I locally deleted all highlighters except main (to prevent their tests from running) and ran () { git checkout "$1" zsh-syntax-highlighting.plugin.zsh zsh-syntax-highlighting.zsh highlighters/main/main-highlighter.zsh } on various commits.

I found that 3c5f63d runs 27% more slowly than its parent, and 343ec1061fda6ecbc9782e33a8e4539525899594 runs 26% more slowly than 0.7.1. Furthermore, reverting that patch (one hunk conflicts, but I just ignored that) fixes the problem.

Activity

added this to the 0.8.0 milestone on May 4, 2020
added a commit that references this issue on Apr 6, 2024
06710f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @danielshahaf

        Issue actions

          Global aliases cause performance regression · Issue #728 · zsh-users/zsh-syntax-highlighting