Skip to content

Conversation

danielshahaf
Copy link
Member

Sometimes I type echo hello <set-mark-command>world<quote-region> (the default bindings are <C-Space> and <M-"> respectively). This patch will cause the word world to be highlighted whilst its being typed.

Should an inactive region be highlighted differently from an active one? Some widgets behave differently on active and inactive regions, e.g., pasting will delete the region only the region is active. There are more differences, particularly in vi mode (grep Src/Zle/ for if/switch statements on the C variable region_active).

/cc @m0vie - this is in the same general area as #256 and #257

@danielshahaf
Copy link
Member Author

Conflicts due to 4849ef3 in master.

@danielshahaf
Copy link
Member Author

The MARK > 0 test is probably wrong: MARK and CURSOR are zero-based, if the mark is set before the first character of the buffer then MARK would legitimately be zero.

@nicoulaj nicoulaj closed this Aug 15, 2017
@nicoulaj nicoulaj reopened this Aug 15, 2017
@nicoulaj
Copy link
Member

(Closing/reopening to trigger continuous integration)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants