Skip to content

apply suffix and isearch zle_highlights on top #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

m0vie
Copy link
Contributor

@m0vie m0vie commented Mar 28, 2016

Now that
38145: ZLE parameters for isearch and completion suffixes
got merged upstream, we can make use of these.

@danielshahaf
Copy link
Member

So, this PR fixes #224 and moots #257, is that correct? How is this PR related to #259, I assume they are independent (both of them needed)?

@danielshahaf
Copy link
Member

In second thought, I think we'll still need to fix #257 separately older zsh.

@m0vie
Copy link
Contributor Author

m0vie commented Mar 29, 2016

Yes, this takes care of #224 and #257 for new versions of zsh. We can't do much for older versions, except disable highlighting in isearch altogether. #259 is completely unrelated. I was gonna close #259 because that does not have the effect I wanted it to have.

@danielshahaf danielshahaf merged commit 79e4d3d into zsh-users:master Mar 31, 2016
@m0vie m0vie deleted the p_zle_highlight branch April 3, 2016 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants