Skip to content

Commit 79bbeea

Browse files
committed
login [nfc]: Relabel TODOs
We just split off these various issues from #35; see #35 (comment)
1 parent 59e3064 commit 79bbeea

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/api/route/realm.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ part 'realm.g.dart';
1212
/// The Zulip server offers this endpoint at the root domain of a server,
1313
/// even when there is no Zulip realm at that domain. This binding, however,
1414
/// only operates on an actual Zulip realm.
15-
// TODO(#35): Perhaps detect realmless root domain, for more specific onboarding feedback.
15+
// TODO(#107): Perhaps detect realmless root domain, for more specific onboarding feedback.
1616
// See thread, and the zulip-mobile code and chat thread it links to:
1717
// https://github.com/zulip/zulip-flutter/pull/55#discussion_r1160267577
1818
Future<GetServerSettingsResult> getServerSettings({

lib/widgets/login.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ class _AddAccountPageState extends State<AddAccountPage> {
154154
if (!context.mounted) {
155155
return;
156156
}
157-
// TODO(#35) give more helpful feedback; see `fetchServerSettings`
157+
// TODO(#105) give more helpful feedback; see `fetchServerSettings`
158158
// in zulip-mobile's src/message/fetchActions.js. Needs #37.
159159
showErrorDialog(context: context,
160160
title: 'Could not connect', message: 'Failed to connect to server:\n$url');
@@ -280,7 +280,7 @@ class _PasswordLoginPageState extends State<PasswordLoginPage> {
280280
realmUrl: realmUrl, username: username, password: password);
281281
} on Exception { // TODO(#37): distinguish API exceptions
282282
if (!context.mounted) return;
283-
// TODO(#35) give more helpful feedback. Needs #37. The RN app is
283+
// TODO(#105) give more helpful feedback. Needs #37. The RN app is
284284
// unhelpful here; we should at least recognize invalid auth errors, and
285285
// errors for deactivated user or realm (see zulip-mobile#4571).
286286
showErrorDialog(context: context, title: 'Login failed');
@@ -296,7 +296,7 @@ class _PasswordLoginPageState extends State<PasswordLoginPage> {
296296
}
297297

298298
final globalStore = GlobalStoreWidget.of(context);
299-
// TODO(#35): give feedback to user on SQL exception, like dupe realm+user
299+
// TODO(#108): give feedback to user on SQL exception, like dupe realm+user
300300
final accountId = await globalStore.insertAccount(AccountsCompanion.insert(
301301
realmUrl: realmUrl,
302302
email: result.email,
@@ -345,7 +345,7 @@ class _PasswordLoginPageState extends State<PasswordLoginPage> {
345345
: 'Please enter your username.';
346346
}
347347
if (requireEmailFormatUsernames) {
348-
// TODO(#35): validate is in the shape of an email
348+
// TODO(#106): validate is in the shape of an email
349349
}
350350
return null;
351351
},

0 commit comments

Comments
 (0)