-
Notifications
You must be signed in to change notification settings - Fork 309
login: Give useful hints, format help, and error feedback in UI #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 2, 2023
…bile For the corresponding logic in zulip-mobile, see src/start/RealmInputScreen.js. Between the URL parser we use here and the one we use in zulip-mobile, probably the set of rejected strings won't match exactly, but it'd be a surprising bug if either one rejects reasonable strings that we could've used. As in zulip-mobile, we distinguish validation errors we want to report immediately, from ones we'll wait to report until the user presses submit. (Compare this revision's `shouldDeferFeedback` to the first bit of zulip-mobile's `getSuggestion`.) Also add some tests, in an improvement over zulip-mobile. Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 2, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 2, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 2, 2023
…bile Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 3, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 3, 2023
At least on iOS, this lets me use my password manager to autofill my email and password together in a single interaction. Before, it was only autofilling the password field. Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 3, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 3, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 3, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 3, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 3, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 3, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 5, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 5, 2023
This should allow using a password manager to autofill an email and password together in a single interaction. Before, in my testing, it was only autofilling the password field. Tested by Chris on iOS and by Greg on Android. Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 5, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 5, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 5, 2023
Fixes-partly: zulip#35
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 9, 2023
Fixes-partly: zulip#35
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 9, 2023
This should allow using a password manager to autofill an email and password together in a single interaction. Before, in my testing, it was only autofilling the password field. Tested by Chris on iOS and by Greg on Android. Fixes-partly: zulip#35
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 9, 2023
Fixes-partly: zulip#35
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 9, 2023
Fixes-partly: zulip#35
gnprice
pushed a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 9, 2023
Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 12, 2023
…bile For the corresponding logic in zulip-mobile, see src/start/RealmInputScreen.js. Between the URL parser we use here and the one we use in zulip-mobile, probably the set of rejected strings won't match exactly, but it'd be a surprising bug if either one rejects reasonable strings that we could've used. As in zulip-mobile, we distinguish validation errors we want to report immediately, from ones we'll wait to report until the user presses submit. (Compare this revision's `shouldDeferFeedback` to the first bit of zulip-mobile's `getSuggestion`.) Also add some tests, in an improvement over zulip-mobile. Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 12, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 12, 2023
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 12, 2023
…bile Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 13, 2023
…mostly (Leaving a TODO to actually do form validation that the username is an email address, when appropriate.) Fixes-partly: zulip#35
chrisbobbe
added a commit
to chrisbobbe/zulip-flutter
that referenced
this issue
May 16, 2023
…mostly (Leaving a TODO to actually do form validation that the username is an email address, when appropriate.) Fixes-partly: zulip#35
chrisbobbe
added a commit
that referenced
this issue
May 23, 2023
We just split off these various issues from #35; see #35 (comment)
chrisbobbe
added a commit
that referenced
this issue
May 23, 2023
We're now tracking all our planned work in this area with more specific TODOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This will be a followup to #11, where I think for the first iteration we'll leave this aspect out, or at least incomplete.
When the user is trying to log into an account, we should:
https://
left implicit;In particular we should bring this to at least the same level of helpfulness as we currently have in the RN app.
The text was updated successfully, but these errors were encountered: