Skip to content

login: Give useful hints, format help, and error feedback in UI #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Mar 30, 2023 · 1 comment
Closed

login: Give useful hints, format help, and error feedback in UI #35

gnprice opened this issue Mar 30, 2023 · 1 comment
Labels

Comments

@gnprice
Copy link
Member

gnprice commented Mar 30, 2023

This will be a followup to #11, where I think for the first iteration we'll leave this aspect out, or at least incomplete.

When the user is trying to log into an account, we should:

  • accept a URL with the leading https:// left implicit;
  • give useful hints about what the "Zulip server URL" field is asking for;
  • give useful feedback in the UI when the URL is ill-formed;
  • give useful feedback when the URL isn't of a Zulip server, or the server can't be reached;
  • give useful feedback when the email they try to enter isn't in the shape of an email;
  • give useful feedback when the server doesn't accept the login;
  • perhaps more in the same vein.

In particular we should bring this to at least the same level of helpfulness as we currently have in the RN app.

chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 2, 2023
…bile

For the corresponding logic in zulip-mobile, see
src/start/RealmInputScreen.js.

Between the URL parser we use here and the one we use in
zulip-mobile, probably the set of rejected strings won't match
exactly, but it'd be a surprising bug if either one rejects
reasonable strings that we could've used.

As in zulip-mobile, we distinguish validation errors we want to
report immediately, from ones we'll wait to report until the user
presses submit. (Compare this revision's `shouldDeferFeedback` to
the first bit of zulip-mobile's `getSuggestion`.)

Also add some tests, in an improvement over zulip-mobile.

Fixes-partly: zulip#35
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 2, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 2, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 2, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 3, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 3, 2023
At least on iOS, this lets me use my password manager to autofill my
email and password together in a single interaction. Before, it was
only autofilling the password field.

Fixes-partly: zulip#35
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 3, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 3, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 3, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 3, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 3, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 3, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 5, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 5, 2023
This should allow using a password manager to autofill an email and
password together in a single interaction. Before, in my testing, it
was only autofilling the password field.

Tested by Chris on iOS and by Greg on Android.

Fixes-partly: zulip#35
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 5, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 5, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 5, 2023
gnprice pushed a commit to chrisbobbe/zulip-flutter that referenced this issue May 9, 2023
gnprice pushed a commit to chrisbobbe/zulip-flutter that referenced this issue May 9, 2023
This should allow using a password manager to autofill an email and
password together in a single interaction. Before, in my testing, it
was only autofilling the password field.

Tested by Chris on iOS and by Greg on Android.

Fixes-partly: zulip#35
gnprice pushed a commit to chrisbobbe/zulip-flutter that referenced this issue May 9, 2023
gnprice pushed a commit to chrisbobbe/zulip-flutter that referenced this issue May 9, 2023
gnprice pushed a commit to chrisbobbe/zulip-flutter that referenced this issue May 9, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 12, 2023
…bile

For the corresponding logic in zulip-mobile, see
src/start/RealmInputScreen.js.

Between the URL parser we use here and the one we use in
zulip-mobile, probably the set of rejected strings won't match
exactly, but it'd be a surprising bug if either one rejects
reasonable strings that we could've used.

As in zulip-mobile, we distinguish validation errors we want to
report immediately, from ones we'll wait to report until the user
presses submit. (Compare this revision's `shouldDeferFeedback` to
the first bit of zulip-mobile's `getSuggestion`.)

Also add some tests, in an improvement over zulip-mobile.

Fixes-partly: zulip#35
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 12, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 12, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 12, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 13, 2023
…mostly

(Leaving a TODO to actually do form validation that the username is
an email address, when appropriate.)

Fixes-partly: zulip#35
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 16, 2023
…mostly

(Leaving a TODO to actually do form validation that the username is
an email address, when appropriate.)

Fixes-partly: zulip#35
chrisbobbe added a commit that referenced this issue May 23, 2023
We just split off these various issues from #35; see
  #35 (comment)
chrisbobbe added a commit that referenced this issue May 23, 2023
We're now tracking all our planned work in this area with more
specific TODOs.
@gnprice gnprice moved this to Done in Flutter app Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants