Skip to content

accounts ui: List of accounts doesn't scroll when more than a screenful #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue May 19, 2023 · 2 comments · Fixed by #593
Closed

accounts ui: List of accounts doesn't scroll when more than a screenful #100

chrisbobbe opened this issue May 19, 2023 · 2 comments · Fixed by #593
Assignees
@sm-sayedi
Labels
a-design Visual and UX design
Milestone
M5b: Launch goals

Comments

@chrisbobbe
Copy link
Collaborator

No description provided.

chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 19, 2023
@chrisbobbe
accounts ui: Make list of accounts scrollable
3aa29b2 
Fixes: zulip#100
@chrisbobbe chrisbobbe mentioned this issue May 19, 2023
Merged
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue May 23, 2023
@chrisbobbe
accounts ui: Make list of accounts scrollable
af0af36 
Fixes: zulip#100
@gnprice gnprice added the a-design Visual and UX design label Jun 14, 2023
@gnprice gnprice added this to the Beta milestone Jun 15, 2023
@gnprice gnprice modified the milestones: Beta, Launch Sep 22, 2023
@sm-sayedi
Copy link
Collaborator

I would like to work on this issue!

My work so far:

Before After

@sm-sayedi sm-sayedi mentioned this issue Mar 26, 2024
Merged
@gnprice
Copy link
Member

gnprice commented Mar 26, 2024

Sure — please go ahead. That behavior looks good.

sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 26, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
85ec4d3 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scroll properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
@sm-sayedi sm-sayedi mentioned this issue Mar 26, 2024
Merged
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 26, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
489c34b 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scrolls properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 27, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
8bf59c5 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scrolls properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 27, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
5c62d37 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scrolls properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 27, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
d609843 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scrolls properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 27, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
0614b90 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scrolls properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 27, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
f752479 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scrolls properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 28, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
a246461 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scrolls properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
sm-sayedi added a commit to sm-sayedi/zulip-flutter that referenced this issue Mar 29, 2024
@sm-sayedi
accounts-ui: Make accounts list scrollable
680b9ff 
Before this fix, the list of accounts did not scroll
when they were more than a screenful and would
show an overflow error on the screen.

After this fix, the list of accounts scrolls properly
with no overflow error and without shifting other
content offscreen.

Fixes: zulip#100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sm-sayedi sm-sayedi

Labels
a-design Visual and UX design
Projects
Flutter app
Status: Done
Milestone
M5b: Launch goals
Development

Successfully merging a pull request may close this issue.

accounts-ui: Make accounts list scrollable sm-sayedi/zulip-flutter
3 participants
@gnprice @chrisbobbe @sm-sayedi