Skip to content

Handle message_embed website previews #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnprice opened this issue Oct 21, 2024 · 1 comment · Fixed by #1049
Closed

Handle message_embed website previews #1016

gnprice opened this issue Oct 21, 2024 · 1 comment · Fixed by #1049
Assignees
@rajveermalviya
Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Milestone
M5a: Launch blockers

Comments

@gnprice
Copy link
Member

gnprice commented Oct 21, 2024

I.e., this Zulip feature:
https://zulip.com/help/image-video-and-website-previews#configure-whether-website-previews-are-shown
which we've also called "inline URL preview".

The HTML elements for these look like <div class="message_embed">. Example message here:
https://chat.zulip.org/#narrow/stream/101-design/topic/auto-linkification.20of.20issues/near/193181

On chat.zulip.org these are scarce because it's a realm-level setting which we turned off after a brief period enabled, so it's easy for us to forget about this feature. But on realms that have the setting turned on, they'll naturally be much more common.

These appeared in the results of the survey #917 / #190 of unimplemented content features. Thanks to @andersk for pointing out (#965 (comment)) that this is a current feature.
@gnprice gnprice added the a-content Parsing and rendering Zulip HTML content, notably message contents label Oct 21, 2024
@gnprice gnprice added this to the Launch milestone Oct 21, 2024
@gnprice gnprice mentioned this issue Oct 21, 2024
Open
@rajveermalviya rajveermalviya self-assigned this Nov 18, 2024
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Nov 18, 2024
@rajveermalviya
content: Handle message_embed website previews
8fba3fe 
Fixes: zulip#1016
@rajveermalviya rajveermalviya mentioned this issue Nov 18, 2024
Merged
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Dec 11, 2024
@rajveermalviya
content: Handle message_embed website previews
5b7b364 
Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Dec 11, 2024
@rajveermalviya
content: Handle message_embed website previews
533fa33 
Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Dec 12, 2024
@rajveermalviya
content: Handle message_embed website previews
aeabbe6 
Fixes: zulip#1016
@chrisbobbe
Copy link
Collaborator

I saw a request for this in the Google Play Console:

The beta is quite improvement. Especially the topic mute/unmute is great and I hope the HTML previews are going to get implemented soon.

@gnprice gnprice modified the milestones: M5: Launch, M5-a: Server 10 Jan 14, 2025
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 21, 2025
@rajveermalviya
content: Handle message_embed website previews
019edde 
The LinkPreview widget follows the Web styling, like having different layout
for larger viewports (> 576), and any other constraints that are empirically
present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 21, 2025
@rajveermalviya
content: Handle message_embed website previews
6e37971 
The LinkPreview widget follows the Web styling, like having different layout
for larger viewports (> 576), and any other constraints that are empirically
present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jan 21, 2025
@rajveermalviya
content: Handle message_embed website previews
70ea927 
The LinkPreview widget follows the Web styling, like having different layout
for larger viewports (> 576), and any other constraints that are empirically
present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 10, 2025
@rajveermalviya
content: Handle message_embed website previews
49cf612 
The LinkPreview widget follows the Web styling, like having different layout
for larger viewports (> 576), and any other constraints that are empirically
present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 10, 2025
@rajveermalviya
content: Handle message_embed website previews
aa4c9ea 
The LinkPreview widget follows the Web styling, like having different layout
for larger viewports (> 576), and any other constraints that are empirically
present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 20, 2025
@rajveermalviya
content: Handle message_embed website previews
193280a 
Implements support for displaying website previews messages,
follows the Web styling, like having different layout for
larger viewports (> 576), and any other constraints that are
empirically present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 24, 2025
@rajveermalviya
content: Handle message_embed website previews
ea3df93 
Implements support for displaying website previews messages,
follows the Web styling, like having different layout for
larger viewports (> 576), and any other constraints that are
empirically present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 24, 2025
@rajveermalviya
content: Handle message_embed website previews
1b27644 
Implements support for displaying website previews messages,
follows the Web styling, like having different layout for
larger viewports (> 576), and any other constraints that are
empirically present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 24, 2025
@rajveermalviya
content: Handle message_embed website previews
0d8107d 
Implements support for displaying website previews messages,
follows the Web styling, like having different layout for
larger viewports (> 576), and any other constraints that are
empirically present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 24, 2025
@rajveermalviya
content: Handle message_embed website previews
6cd7ac5 
Implements support for displaying website previews messages,
follows the Web styling, like having different layout for
larger viewports (> 576), and any other constraints that are
empirically present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 26, 2025
@rajveermalviya
content: Handle message_embed website previews
784d57d 
Implements support for displaying website previews messages,
follows the Web styling, like having different layout for
larger viewports (> 576), and any other constraints that are
empirically present on Web.

Fixes: zulip#1016
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Feb 26, 2025
@rajveermalviya
content: Handle message_embed website previews
a40d008 
Implements support for displaying website previews messages,
follows the Web styling, like having different layout for
larger viewports (> 576), and any other constraints that are
empirically present on Web.

Fixes: zulip#1016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajveermalviya rajveermalviya

Labels
a-content Parsing and rendering Zulip HTML content, notably message contents
Projects
Flutter app
Status: Done
Milestone
M5a: Launch blockers
Development

Successfully merging a pull request may close this issue.

content: Handle link previews rajveermalviya/zulip-flutter
3 participants
@gnprice @chrisbobbe @rajveermalviya