Skip to content

App fails to start on chat.zulip.org with new can_remove_subscribers_group format #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnprice opened this issue Nov 25, 2024 · 0 comments · Fixed by #1084
Closed

App fails to start on chat.zulip.org with new can_remove_subscribers_group format #1082

gnprice opened this issue Nov 25, 2024 · 0 comments · Fixed by #1084
Assignees
@gnprice
Labels
a-api Implementing specific parts of the Zulip server API
Milestone
M4: Wider beta

Comments

@gnprice
Copy link
Member

gnprice commented Nov 25, 2024

Since a recent deployment on chat.zulip.org, the app fails to load server data for many users there. Chat thread:
https://chat.zulip.org/#narrow/channel/243-mobile-team/topic/Infinite.20loading.20flutter.20app/near/1987288

The cause is that feature level 320 made can_remove_subscribers_group a group-settings value instead of always an integer group ID, and we expect an integer. So the server's response to registerQueue is malformed.

The immediate fix within the app is that we'll stop deserializing that field at all — we don't actually use it. Further discussion:
https://chat.zulip.org/#narrow/channel/378-api-design/topic/migrating.20settings.20to.20user-groups.20framework/near/1987303
@gnprice gnprice added the a-api Implementing specific parts of the Zulip server API label Nov 25, 2024
@gnprice gnprice added this to the M4: Wider beta milestone Nov 25, 2024
@gnprice gnprice self-assigned this Nov 25, 2024
This was referenced Nov 25, 2024
Open
Open
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Nov 25, 2024
@gnprice
api: Cut ZulipStream.canRemoveSubscribersGroup as it changes format
ecc8d1c 
This field is becoming a group-setting value.  We haven't yet
implemented those (that's zulip#814), so we can no longer handle this field
until we do that work.  Conveniently we weren't actually making any
use of this field, though -- so for now, just ignore it.

Fixes: zulip#1082
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Nov 25, 2024
@gnprice
api: Cut ChannelPropertyName.canRemoveSubscribersGroup
17a9fc7 
This is affected by the same root cause as zulip#1082, though the impact
here is much smaller: this one only applies to an event at the moment
someone edits one of these settings.
@gnprice gnprice mentioned this issue Nov 25, 2024
Merged
chrisbobbe pushed a commit that referenced this issue Nov 25, 2024
@gnprice @chrisbobbe
api: Cut ZulipStream.canRemoveSubscribersGroup as it changes format
48fb81b 
This field is becoming a group-setting value.  We haven't yet
implemented those (that's #814), so we can no longer handle this field
until we do that work.  Conveniently we weren't actually making any
use of this field, though -- so for now, just ignore it.

Fixes: #1082
chrisbobbe pushed a commit that referenced this issue Nov 25, 2024
@gnprice @chrisbobbe
api: Cut ChannelPropertyName.canRemoveSubscribersGroup
85b9c43 
This is affected by the same root cause as #1082, though the impact
here is much smaller: this one only applies to an event at the moment
someone edits one of these settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnprice gnprice

Labels
a-api Implementing specific parts of the Zulip server API
Projects
Flutter app
Status: Done
Milestone
M4: Wider beta
Development

Successfully merging a pull request may close this issue.

api: Cut ZulipStream.canRemoveSubscribersGroup as it changes format gnprice/zulip-flutter
1 participant
@gnprice