Skip to content

compose: Give better media-picker UI on Android #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisbobbe opened this issue May 25, 2023 · 3 comments
Closed

compose: Give better media-picker UI on Android #114

chrisbobbe opened this issue May 25, 2023 · 3 comments
Labels
a-compose Compose box, autocomplete, attaching files/images

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented May 25, 2023

See #56 (comment) (referring to what we currently offer on the "Attach images or videos" button in the compose box):

Hmm no, I don't think this is the fancy new PhotoPicker API

Dang, yeah.

That PhotoPicker API is available through image_picker: https://pub.dev/packages/image_picker_android#photo-picker

So that'd be an option. But pending flutter/flutter#89159, it'd lack videos unless we had two separate buttons.

That issue now has a linked PR! 🤞 flutter/packages#3892 So hopefully we can take care of this reasonably soon, by using image_picker instead of file_picker for this.

@gnprice gnprice added m-beta a-compose Compose box, autocomplete, attaching files/images labels May 26, 2023
@gnprice gnprice added this to the Beta milestone May 27, 2023
@gnprice gnprice removed the m-beta label May 27, 2023
@gnprice
Copy link
Member

gnprice commented Jul 4, 2023

And that upstream issue flutter/flutter#89159 is complete (since a few weeks ago). So the first-party image_picker should be able to take care of this for us.

Also the first-party file_selector just grew Android support:

We'd noted in #57 that that was missing, which led us to use file_picker there. But now we may be able to replace both uses of file_picker with first-party plugins.

This means there's overlap in functionality between the two first-party plugins file_selector and image_picker:

Not sure which to use where they overlap. Quite possibly either one would be fine.

@gnprice gnprice modified the milestones: Beta, Launch Sep 22, 2023
@gnprice
Copy link
Member

gnprice commented Jul 31, 2024

This appears to have been fixed — I just tried the "photo" icon under the compose box, on Android, and got what looks like the fancy new "photo picker" UI.

@gnprice
Copy link
Member

gnprice commented Jul 31, 2024

Closing because the issue seems to have been fixed.

I am puzzled as to what would have fixed it, though:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images
Projects
Status: Done
Development

No branches or pull requests

2 participants